Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/precompute nliq #125

Merged
merged 17 commits into from
Feb 12, 2024
Merged

Feat/precompute nliq #125

merged 17 commits into from
Feb 12, 2024

Conversation

franzns
Copy link
Collaborator

@franzns franzns commented Feb 8, 2024

Pre computing normalizedLiqudity

@franzns franzns changed the base branch from v3-main to v3-canary February 8, 2024 07:58
brunoguerios
brunoguerios reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@brunoguerios brunoguerios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small comment thinking about edge cases, but other than that code makes sense 👍

modules/pool/lib/pool-normalized-liquidty.ts Outdated Show resolved Hide resolved
@franzns franzns marked this pull request as ready for review February 9, 2024 11:14
@franzns franzns linked an issue Feb 9, 2024 that may be closed by this pull request
pre compute normalized liquidity #90
Closed
@franzns franzns merged commit 71d5d59 into v3-canary Feb 12, 2024
1 check passed
@gmbronco gmbronco deleted the feat/precompute-nliq branch March 11, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoguerios brunoguerios brunoguerios left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre compute normalized liquidity
2 participants
@franzns @brunoguerios